Overhaul SymbolLoader #280
Conversation
fealebenpae
force-pushed
the
fealebenpae/symbol-loader-bundle-caching
branch
from
429527e
to
7839e29
Compare
| #endif | ||
| } else { | ||
| baseUrl = [[NSBundle mainBundle] privateFrameworksURL]; |
There was a problem hiding this comment.
Can you share some frameworks that would need this? I'm just wondering how this is helpful, because I don't remember having anything similar before. Or are these the embeded frameworks.
There was a problem hiding this comment.
This is supposed to handle embedded frameworks that export functions and other symbols. They've worked up to now, yes, but they've relied on the RTLD_GLOBAL fallback.
fealebenpae
force-pushed
the
fealebenpae/symbol-loader-bundle-caching
branch
from
7839e29
to
448f00a
Compare
| @@ -6,75 +6,146 @@ | |||
| // Copyright (c) 2014 г. Telerik. All rights reserved. | |||
There was a problem hiding this comment.
You could also rename the license header from SymbolLoader.cpp to SymbolLoader.mm if you want :D
fealebenpae
force-pushed
the
fealebenpae/symbol-loader-bundle-caching
branch
from
448f00a
to
935e638
Compare
| } | ||
| NSURL* bundleUrl = [NSURL URLWithString:frameworkPathStr relativeToURL:baseUrl]; | ||
| WTF::RetainPtr<CFBundleRef> bundle = adoptCF(CFBundleCreate(kCFAllocatorDefault, (CFURLRef)bundleUrl)); | ||
| WTF::dataLogF("NativeScript loaded bundle %s", bundleUrl.absoluteString.UTF8String); |
There was a problem hiding this comment.
You could append '\n' at the end to make it more clear.
|
This branch seems to crash on our tests when the |
fealebenpae
force-pushed
the
fealebenpae/symbol-loader-bundle-caching
branch
2 times, most recently
from
e9fabc2
to
41f27ab
Compare
Make SymbolLoader cache by the ModuleMeta pointer, which is unique. SymbolLoader now supports embedded frameworks. Stubbed support for dylibs.
fealebenpae
force-pushed
the
fealebenpae/symbol-loader-bundle-caching
branch
from
41f27ab
to
a215614
Compare
|
Accelerate and Metal report themselves as non-system frameworks so this failed the isSystem check and resulted in paths to bundles that aren't there. I've added nil guards for |
|
👍 |
…undle-caching Overhaul SymbolLoader
Make SymbolLoader cache by the ModuleMeta pointer, which is unique.
SymbolLoader now supports embedded frameworks.
Stubbed support for dylibs.
Fixes #273