fix(console-dir): Fix missing console.dir output #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginev
requested review from
mbektchiev,
rosen-vladimirov,
petekanev and
tdermendjiev
ginev
force-pushed
the
ginev/console-dir-fix
branch
4 times, most recently
from
81c8bf7
to
337755a
Compare
|
run ci |
ginev
force-pushed
the
ginev/console-dir-fix
branch
4 times, most recently
from
19e606b
to
ea94b7b
Compare
|
run ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues with calling
console.diron objects in an iOS app. There are two aspects here:console.log/console.dirmessages - update(cli): Improve filtering of iOS logs nativescript-cli#3389console.dirbehavior with android runtime's by introducing thesmartStringifyFunctionto handle circular references adequately.Related issue: #875
P.S.
There are functional tests covering this functionality.