fix(debugging): Don't close inspector socket after 30 sec. timeout #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbektchiev
force-pushed
the
bektchiev/random-inspector-port-on-device
branch
from
b6e4540
to
108d369
Compare
|
run ci |
1 similar comment
|
run ci |
We had to close it in order to have the hardcoded port number 18181
available for other apps after finishing (or never starting) a
debugging session. Without this timeout the first app that opened
the port would take it as long as it's running and would prevent
any subsequent debugging attempts of another app on the same iOS device;
or even the same app on another iOS Simulator on the same Mac machine.
From now on, if the 18181 port is unavailable, a random free port \
will be used and its number will be output in the application log.
When starting a debug session, {N} CLI will monitor the logs
in order to receive the allocated port number for the current
session.
The reason for this change is that due to the new logic of never closing it, any application with ios-runtime 4.1 or later could permanently take it and prevent apps with an older runtime version from being debugged. We still prefer to have a default port for easier local development using `debugger-proxy.js`
mbektchiev
force-pushed
the
bektchiev/random-inspector-port-on-device
branch
from
108d369
to
6781d25
Compare
mbektchiev
changed the title
mbektchiev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The inspector listening socket is being closed 30 sec. after the last
activity on it (opening, disconnection, etc). It had to be closed in order
to have the hardcoded port number 18181 available for other apps after
finishing (or never starting) a debugging session. Without this timeout
the first app that opened the port would take it for as long as it's running
and would prevent any subsequent debugging attempts of another app on
the same iOS device; or even any {N} app on any iOS Simulator on the
same Mac machine.
What is the new behavior?
From now on, the default port becomes 18182 and if it is unavailable,
a random free port will be used. Its number will be output in the
application log. When starting a debug session, {N} CLI will monitor
the logs in order to receive the allocated port number for the current
session.
This will allow to connect the frontend at any moment after starting a
debug session, instead of failing after the 30 seconds have elapsed.
This PR has to be merged along with NativeScript/nativescript-cli#3540. Wait for it to be approved.