Get debugger port from device logs #3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Fatme
force-pushed
the
fatme/ios-debugger-port
branch
2 times, most recently
from
0481e6f
to
107b601
Compare
|
run ci |
1 similar comment
|
run ci |
Fatme
force-pushed
the
fatme/ios-debugger-port
branch
from
107b601
to
783d083
Compare
Fatme
force-pushed
the
fatme/ios-debugger-port
branch
from
783d083
to
c5852d0
Compare
|
run ci |
Fatme
commented
May 2, 2018
| private attachToStartingApplicationEvent(device: Mobile.IDevice): void { | ||
| device.applicationManager.on(STARTING_IOS_APPLICATION_EVENT_NAME, (data: IIOSDebuggerPortData) => { | ||
| this.$logger.trace(STARTING_IOS_APPLICATION_EVENT_NAME, data); | ||
| const timer = setTimeout(() => { |
There was a problem hiding this comment.
Consider if this is needed.
Fatme
commented
May 2, 2018
| const factory = async () => { | ||
| const socket = device ? await device.connectToPort(inspectorBackendPort) : net.connect(inspectorBackendPort); | ||
| const port = await this.$iOSDebuggerPortService.getPort({ deviceId: debugData.deviceIdentifier, appId: debugData.applicationIdentifier }); |
There was a problem hiding this comment.
Thrown an error if port is null
Fatme
force-pushed
the
fatme/ios-debugger-port
branch
3 times, most recently
from
09fb48d
to
9e5390d
Compare
Fatme
force-pushed
the
fatme/ios-debugger-port
branch
3 times, most recently
from
5b08ab7
to
b1d750d
Compare
|
run ci |
| super(); | ||
| } | ||
|
|
||
| public startLookingForDebuggerPort(device: Mobile.IDevice): void { |
There was a problem hiding this comment.
I would use a more generic names for these methods, for example startParsingLog. The reason is that in the near future we may use the processDeviceLogResponse to detect when application is started and stopped on iOS. The method may have different regexes and emit different events, based on the information from the logs.
However, we can change this easily in the future, so this is not a merge stopper.
| export class IOSDebuggerPortService implements IIOSDebuggerPortService { | ||
| private mapDebuggerPortData: IDictionary<IIOSDebuggerPortStoredData> = {}; | ||
| private static DEFAULT_PORT = 18181; | ||
| private static MIN_REQUIRED_FRAMEWORK_VERSION = "4.0.0"; |
There was a problem hiding this comment.
this should be something like 4.1.0- (the current next maybe)
Fatme
force-pushed
the
fatme/ios-debugger-port
branch
from
b1d750d
to
cfc2573
Compare
Fatme
force-pushed
the
fatme/ios-debugger-port
branch
from
5b74cf9
to
75cce33
Compare
|
run ci |
rosen-vladimirov
approved these changes
May 21, 2018
Fatme
force-pushed
the
fatme/ios-debugger-port
branch
from
75cce33
to
f6b4b8e
Compare
|
run ci |
Fatme
force-pushed
the
fatme/ios-debugger-port
branch
2 times, most recently
from
3b0a353
to
c0c29b6
Compare
|
run ci |
Fatme
force-pushed
the
fatme/ios-debugger-port
branch
from
a2bc020
to
2878b16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
The inspector listening socket is being closed 30 sec. after the last activity on it (opening, disconnection, etc). It had to be closed in order to have the hardcoded port number 18181
available for other apps after finishing (or never starting) a
debugging session. Without this timeout the first app that opened
the port would take it as long as it's running and would prevent
any subsequent debugging attempts of another app on the same iOS device;
or even the same app on another iOS Simulator on the same Mac machine.
This leads to unavailability to run fast sync on multiples simulators.
What is the new behavior?
From now on, the port is printed from
ios-runtimein devices logs. {N} CLI parses the logs and searches for specified string. The string should be in following format:This will allow to connect the frontend at any moment after starting a debug session, instead of failing after the 30 seconds have elapsed.
Should be merged after these:
telerik/mobile-cli-lib#1087
NativeScript/ios-sim-portable#103
Relying on this:
NativeScript/ios-jsc#907
Implementing:
#3321