Skip to content

Commit

Permalink
refactor: stop exporting NativeScriptModule from platform (#701)
Browse files Browse the repository at this point in the history
Importing NativeScriptModule from "nativescript-angular/platform" leads to
including @angular/compiler in the bundle when doing AoT compilation
with webpack. Import from "nativescript-angular/nativescript.module"
should be used instead.

BREAKING CHANGE: User applications cannot import NativeScriptModule from
"nativescript-angular/platform" anymore.
Migration:
Before:
```
import { NativeScriptModule } from "nativescript-angular/platform";
```
After
```
import { NativeScriptModule } from
"nativescript-angular/nativescript.module";
```
  • Loading branch information
sis0k0 committed Mar 22, 2017
1 parent c7837ed commit 409e717
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 0 additions & 2 deletions nativescript-angular/platform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ import "./dom-adapter";
import { NativeScriptElementSchemaRegistry } from "./schema-registry";
import { FileSystemResourceLoader } from "./resource-loader";

export { NativeScriptModule } from "./nativescript.module";

export const NS_COMPILER_PROVIDERS = [
COMPILER_PROVIDERS,
{
Expand Down
2 changes: 1 addition & 1 deletion tests/app/snippets/navigation/page-outlet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ import { TestApp, registerTestApp } from "../../tests/test-app";
import { ApplicationRef } from "@angular/core";
import { Router, NavigationStart, NavigationEnd } from "@angular/router";
// >> page-outlet-example
import { Component, NgModule } from "@angular/core";
import { platformNativeScriptDynamic } from "nativescript-angular/platform";
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
import { Component, NgModule } from '@angular/core';
import { NativeScriptRouterModule } from "nativescript-angular/router";

import { routes } from "./app.routes";
Expand Down
3 changes: 2 additions & 1 deletion tests/app/tests/test-app.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { NativeScriptModule, platformNativeScriptDynamic } from "nativescript-angular/platform";
import { platformNativeScriptDynamic } from "nativescript-angular/platform";
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
import { NativeScriptRouterModule } from "nativescript-angular/router";
import {
Type, Component, ComponentRef,
Expand Down

0 comments on commit 409e717

Please sign in to comment.