fix(modal): throw from tns-core-modules is now properly caught and re…

…jected
NativeScript · Jun 27, 2018 · 70730d9 · 70730d9
1 parent dc8080b
commit 70730d9
Showing 1 changed file with 19 additions and 13 deletions.
diff --git a/nativescript-angular/directives/dialogs.ts b/nativescript-angular/directives/dialogs.ts
@@ -76,19 +76,25 @@ export class ModalDialogService {
 
         this.location._beginModalNavigation();
 
-        return new Promise(resolve => {
-            setTimeout(() => this._showDialog({
-                containerRef: viewContainerRef,
-                context,
-                doneCallback: resolve,
-                fullscreen,
-                animated,
-                stretched,
-                pageFactory,
-                parentView,
-                resolver,
-                type,
-            }), 10);
+        return new Promise((resolve, reject) => {
+            setTimeout(() => {
+                try {
+                    this._showDialog({
+                        containerRef: viewContainerRef,
+                        context,
+                        doneCallback: resolve,
+                        fullscreen,
+                        animated,
+                        stretched,
+                        pageFactory,
+                        parentView,
+                        resolver,
+                        type,
+                    });
+                } catch (err) {
+                    reject(err);
+                }
+            }, 10);
         });
     }