fix(location-strategy): crash on going back with router-outlet after closing modal #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
test package_version#latest |
ADjenkov
force-pushed
the
djenkov/router-outlet-fix
branch
from
3725201
to
d524bc8
Compare
|
test package_version#latest |
manoldonev
approved these changes
Feb 21, 2019
MartoYankov
reviewed
Feb 26, 2019
MartoYankov
approved these changes
Feb 26, 2019
ADjenkov
force-pushed
the
djenkov/router-outlet-fix
branch
from
d524bc8
to
5367830
Compare
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: ADjenkov.
|
|
test package_version#latest |
dottodot
pushed a commit
to dottodot/nativescript-angular
that referenced
this pull request
Mar 16, 2019
* master: exclude files from api ref build NS Angular api ref build script fix(location-strategy): crash on going back with router-outlet after closing modal (NativeScript#1748) release: cut the 7.2.2 release (NativeScript#1742) fix(router): routing services should be provided in forRoot only (NativeScript#1729) fix(list-view): Add support for default item template fix(list-view): add support for "defailtTemplate" docs: cut the 7.2.1 release fix: Router tracing does not work with webpack chore: bump package version to 7.2.1 chore: bump package versino tp 7.3.0 test: Add tests for nested primary outlets fix(location-strategy): extend support for nested primary outlets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify location-strategy to better handle
<router-outlets>and modal views:_beginModalNavigationmethod shouldn't setcurrentOutletto null when no outlet for the given Frame found.clearOutletmethod: Do not remove outlet, from outlets collection, who belongs to<router-outlet>since it doesn't have any frames[]findOutletmethod should always respect the current_modalNavigationDepthwhen searching for outlet, since there could be 2 or more identical outlets on different modal views ( primary-> (modal:primary)->(modal2->primary))make
findOutletByModalprivate, since it won't be used outside location-strategy anymoreFix #1735