Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of task completion #185

Closed
cfjedimaster opened this issue Nov 14, 2018 · 3 comments
Closed

Documentation of task completion #185

cfjedimaster opened this issue Nov 14, 2018 · 3 comments
Labels

Comments

@cfjedimaster
Copy link

In the readme, I do not see any examples of working with the task object. How do I know it's done? How do I monitor it? I've seen in the demo some examples, but shouldn't the readme show a bit more in terms of how to handle the upload?

@cfjedimaster
Copy link
Author

Maybe this should be expanded. I'm trying to use the progress event too and while I can console.log the data - shouldn't the docs tell you what is passed to the event?

@lini
Copy link
Contributor

lini commented Nov 16, 2018

I have updated the code samples in the documentation in #186
If you feel that something is not right or needs to be expanded, feel free to submit a PR.

@cfjedimaster
Copy link
Author

This looks really good - thank you!

@lini lini closed this as completed Nov 19, 2018
@ghost ghost removed the question label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants