Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): add options to set notifications channel id, ringtone enabled and auto clear #239

Merged
merged 5 commits into from
Aug 29, 2019

Conversation

mukaschultze
Copy link
Contributor

PR Checklist

What is the current behavior?

Currently, there is no way of changing some options of upload notifications that are available on android upload service.

What is the new behavior?

Three new fields were implemented to allow changing these settings, androidRingToneEnabled androidNotificationChannelID and androidAutoClearNotification

The changes made were based off on #71

@project-bot project-bot bot added this to PRs in Plugins Team Aug 8, 2019
@cla-bot
Copy link

cla-bot bot commented Aug 8, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @mukaschultze.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@mukaschultze
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Aug 8, 2019
@cla-bot
Copy link

cla-bot bot commented Aug 8, 2019

The cla-bot has been summoned, and re-checked this pull request!

@mukaschultze mukaschultze changed the title feat(android): Add options to set notifications channel id, ringtone enabled and auto clear feat(android): add options to set notifications channel id, ringtone enabled and auto clear Aug 8, 2019
Copy link
Contributor

@romulowspp romulowspp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! :D

@VladimirAmiorkov
Copy link
Contributor

VladimirAmiorkov commented Aug 21, 2019

Hi @mukaschultze ,

Thank you for this PR. I reviewed and tested it and it works as expected. The only thing that I noticed is that if both androidRingToneEnabled and androidAutoClearNotification are set to true there will be no ringtone. This looks to be an expected behavior since the notification is automatically removed but I would suggest to add this as a note to the API reference in the README.

Can you make this small update, after that I would be happy to merge and release a new version with this new feature.

README.md Outdated Show resolved Hide resolved
@mukaschultze
Copy link
Contributor Author

@VladimirAmiorkov notes added

@VladimirAmiorkov VladimirAmiorkov merged commit 5824349 into NativeScript:master Aug 29, 2019
Plugins Team automation moved this from PRs to Done Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Plugins Team
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants