Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put mediaTypes as an option #18

Closed
developper89 opened this issue Oct 24, 2016 · 13 comments
Closed

Put mediaTypes as an option #18

developper89 opened this issue Oct 24, 2016 · 13 comments

Comments

@developper89
Copy link

developper89 commented Oct 24, 2016

Hi, I had some trouble removing the video option in the camera view
what i did was to set the mediatypes array to
imagePickerController.mediaTypes = [mediaTypes[0]];
It would be better to pass the type as an option like "public.image" or "public.movie"
and choose between them to enable or disable the photo or video option in the view
Could you add the mediaTypes array as an option or make it settable ?

@nsndeck nsndeck self-assigned this Oct 25, 2016
@nsndeck
Copy link
Contributor

nsndeck commented Oct 25, 2016

Hi @developper89,

We will add such functionality once we are ready to support it. We have plans to improve this plugin to support also video. Unfortunately I cannot commit with an exact time frame when this will be ready, but we will work on it soon.

@fsciuti
Copy link

fsciuti commented Dec 22, 2016

Hello...news about this fix? :)

@valentinstoychev
Copy link

It is scheduled for our next release - 2.5.0 - NativeScript/NativeScript#3241

@fsciuti
Copy link

fsciuti commented Dec 22, 2016

Thanks!!!! :)

@maddy2get
Copy link

Hello, any progress on this yet? Really waiting for this to the my app to release.

@davecoffin
Copy link

was this added in 2.5.0?

@b-hobbs
Copy link

b-hobbs commented Jun 28, 2017

+1

@davecoffin
Copy link

@valentinstoychev @nsndeck This being the recommended camera implementation for nativescript core, I really think it needs some attention. I would imagine a lot of apps are using it (2,336 downloads in the last month), and there are some basic issues in this repo that havent been addressed for months, including this one. Can we get an update?

@Cayan
Copy link

Cayan commented Aug 29, 2017

+1

@adamauckland
Copy link

Hi, this issue seems to be a year old and untouched. Can I just raise a PR to implement removing the "video" option? It doesn't really make sense to show the "video" option when camera.takePicture() returns an image asset.

@DimitarTachev
Copy link

DimitarTachev commented Oct 30, 2017

Hi guys,

Sorry for the long silence and thanks for your contribution! The takePicture method will set only the image media type out of the box in the next plugin version.

The fix is part of pull request #62 and should be available in NPM until the end of the week as the plugin is in a process of becoming a verified one.

As part of this process, the plugin will also follow the recommended plugins structure shown in the plugins seed which will make the community contributions a lot of easier!

@adamauckland
Copy link

Thanks for the great work, DimitarTachev!

@zbranzov
Copy link
Contributor

zbranzov commented Nov 3, 2017

The fix should be already published to NPM. Enjoy!

@zbranzov zbranzov closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests