This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
refactor(angular): provide mainPath instead of entryModule to ng compiler plugin #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compiler plugin
The entryModule path can differ depending on what kind of project you're
using - mobile or web+mobile. While the best solution is to get the
mainPath from angular.json, not all {N} projects have that file. We'll
stick to the standard for web and web+mobile location - `appPath/main.ts`.
sebawita
approved these changes
Aug 13, 2018
manoldonev
approved these changes
Aug 14, 2018
manoldonev
pushed a commit
to NativeScript/nativescript-app-templates
that referenced
this pull request
Jan 9, 2019
…#86) The following changes are in this PR: - the app folder is renamed to src as is in the web Angular projects. - @nativescript/schematics is a devDependency and angular.json file is added. This allows the developers to start using the Angular CLI immediately after creating a project. - App_Resources are now at root level. - nsconfing.json file is added. depends on NativeScript/nativescript-dev-webpack#633 and NativeScript/nativescript-dev-typescript#61
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entryModule path can differ depending on what kind of project you're
using - mobile or web+mobile. While the best solution is to get the
mainPath from angular.json, not all {N} projects have that file. We'll
stick to the standard for web and web+mobile location -
appPath/main.ts.Note - We'll have to update {N} schematics to reflect this change.