Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to login with Facebook #43

Closed
tjvantoll opened this issue Jan 6, 2016 · 3 comments
Closed

Allow users to login with Facebook #43

tjvantoll opened this issue Jan 6, 2016 · 3 comments

Comments

@tjvantoll
Copy link
Contributor

I need to find a good plugin for allowing users to login with Facebook.

@jlooper
Copy link
Contributor

jlooper commented Jan 6, 2016

I started down the road of Facebook login integration for ThisOrThat using this: https://github.com/AntonioCuevaUrraco/nativescript-facebook-login. I was able to login but experienced crashes, I think Antonio said it was fixed but I haven't tested. I left the code commented out here:

https://github.com/jlooper/ThisOrThat-app/blob/master/app/app.js

and here:

https://github.com/jlooper/ThisOrThat-app/blob/master/app/views/login/login.xml
https://github.com/jlooper/ThisOrThat-app/blob/master/app/views/login/login.js

It does allow login and posts the credentials to Everlive, but the crashing behavior stopped me from moving forward. I think it's worth revisiting this strategy but I think we need a vetted plugin from the N team for social logins, it should be in our plugins marketplace, it's really important (ping @valentinstoychev)

@tjvantoll
Copy link
Contributor Author

Thanks Jen!

Agreed. For an official sample I wouldn’t want to include anything that isn’t well vetted. The only 2 plugins Groceries uses today are both in our plugins marketplace.

@tjvantoll
Copy link
Contributor Author

Since we’re trying to keep this sample simple I’m going to close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants