Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance sftp interactiveAuth mode #94

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

lacastorine
Copy link

@lacastorine lacastorine commented Nov 22, 2021

SFTP : interactiveAuth : add ability to pass predefined phrases in 'keyboard-interactive' auth variant.

@lacastorine
Copy link
Author

This also may be a 'hack' solution for - #62 - for me for some sftp ssh2 can't auth with name+password, but it successfully authenticate when enter password via user prompt.

@Natizyskunk
Copy link
Owner

@lacastorine,

I'am actually glad that someone could finally find a "fix" for this bug.

can you confirm me that this is actually working as expected ?
Have you built the vsix extension and tried it ?

Also just before merging anything, can you follow the guidelines available here on how to open a Pull Request please ? 😀

Thank you very much for your help !

@lacastorine lacastorine changed the title sftp : interactiveAuth : enhancement Enhance sftp interactiveAuth mode Nov 25, 2021
@lacastorine
Copy link
Author

lacastorine commented Nov 25, 2021

@Natizyskunk

Have you built the vsix extension and tried it ?

sorry, no. I just compile and change extension.js file... thanks you've asked - with final vsix I've noticed some errors and fix them (mask phrases in interactiveAuth prop, push boolean to tryKeyboard ssh2 prop, fix extension config check on start). (squashed into one commit)

can you confirm me that this is actually working as expected ?

yes, now I can confirm that it works for me as expected

can you follow the guidelines

edit title and description

@lacastorine
Copy link
Author

@Natizyskunk, is there anything else you want me to fix in this PR?

@DamirPecnik
Copy link

When will this get merged?

@Natizyskunk
Copy link
Owner

I'll try to merge it as soon as possible, I hope to have time this week or the next one.

@Natizyskunk Natizyskunk merged commit 84f1e12 into Natizyskunk:master Feb 9, 2022
@Natizyskunk
Copy link
Owner

has been merged in pull-request #114.

@Natizyskunk
Copy link
Owner

Natizyskunk commented Feb 9, 2022

@DamirPecnik,
you can find the fix merged inside the latest release availaible here. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants