dealing with empty midi file #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought that adding a test means a new python file XD |
Natooz
approved these changes
Nov 26, 2023
|
The tests using sustain pedals are expected to fail due to the last update of MIDIToolkit, this is fixed in #108 |
Natooz
added a commit
that referenced
this pull request
Nov 27, 2023
* dealing with empty midi file * add a new test midi tokenizer file instead of changing the original one * delete test_midi_tokenizer * Adding check empty input for _ids_to_tokens as well --------- Co-authored-by: Nathan Fradet <56734983+Natooz@users.noreply.github.com>
Natooz
added a commit
that referenced
this pull request
Nov 28, 2023
* parametrizing tests, improvements in preprocess_midi, fixes for miditoolkit 1.0.1 * fixing absolute path for data aug and io tests * fix test file tree, data aug report saved in out_path * fix in data augmentation saving paths * forced disabling original in out_dir when calling data aug from tok_dataset * using pytest tmp_path to write files, and TEST_LOG_DIR if required * lighter and more elegant MIDI assertions + covering check_midi_equals * better tokenization test sets, set_midi_max_tick method, renamed "nb" contractions to "num", handling empty tokens lists in methods * dealing with empty midi file (#110) * dealing with empty midi file * add a new test midi tokenizer file instead of changing the original one * delete test_midi_tokenizer * Adding check empty input for _ids_to_tokens as well --------- Co-authored-by: Nathan Fradet <56734983+Natooz@users.noreply.github.com> * adding tests for empty MIDI and associated fixes * fixes from tests with empty midi + retry hf hub tests when http errors * fix convert_sequence_to_tokseq when list in last dim is empty * better tok test sets * testing with multiple time resolutions, adjusting notes ends * fix _quantize_time_signatures (delete_equal_successive_time_sig_changes) --------- Co-authored-by: feiyuehchen <46064584+feiyuehchen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see details: #104