Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoding: automatically making sure to decode BPE then completing tokens #138

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented Jan 24, 2024

Following #137 , this PR makes sure the TokSequence in input of tokens_to_midi is automatically preprocessed: tokens have been completed, does it if necessary, and decode BPE if necessary


📚 Documentation preview 📚: https://miditok--138.org.readthedocs.build/en/138/

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (db3ad1d) 91.11% compared to head (576032e) 91.10%.

Files Patch % Lines
miditok/midi_tokenizer.py 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   91.11%   91.10%   -0.02%     
==========================================
  Files          33       33              
  Lines        4886     4891       +5     
==========================================
+ Hits         4452     4456       +4     
- Misses        434      435       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Natooz Natooz merged commit e965eb3 into main Jan 24, 2024
14 checks passed
@Natooz Natooz deleted the automatic-bpe-decode branch January 24, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant