Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_duration_tuples can create overlapping tuples #144

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Natooz
Copy link
Owner

@Natooz Natooz commented Feb 3, 2024

Tokenization tests with this feature are not passing right now, _time_ticks_to_tokens have to be adapted to handle overlapping resolutions


📚 Documentation preview 📚: https://miditok--144.org.readthedocs.build/en/144/

Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (37e28ed) 91.22% compared to head (f46aacb) 91.27%.

Files Patch % Lines
miditok/midi_tokenizer.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   91.22%   91.27%   +0.05%     
==========================================
  Files          33       33              
  Lines        4978     4985       +7     
==========================================
+ Hits         4541     4550       +9     
+ Misses        437      435       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-staff github-staff deleted a comment Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant