Fix issues in Octuple with multiple different-beat time signatures #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I've been playing around with miditok>3.0.0 and found two bugs in the Octuple encoding:
time_signature_range = {2: (1, 2), 4: (1, 4), 8: (1, 8)}
) encodes and decodes positions so that they are shorter than in the original MIDI. For example, note positions in */4 bars are decoded twice as short within the bar. The example MIDI in Incorrect Placement of Time Signatures #131 will not be decoded correctly if there is a time signature */8 in the config.Solution: adapt the position encoding logic from REMI to Octuple.
Solution: move the processing of time signatures above the note duration.
📚 Documentation preview 📚: https://miditok--146.org.readthedocs.build/en/146/