don't trap plugins FP exceptions in DEBUG mode

NatronGitHub · Jan 21, 2022 · 5eaaead · 5eaaead · rodlie · Jan 22, 2022
1 parent c82de4b
commit 5eaaead
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/Engine/Node.cpp b/Engine/Node.cpp
@@ -1202,7 +1202,7 @@ Node::loadKnob(const KnobIPtr & knob,
         break;
 
     }
-  
+
 } // Node::loadKnob
 
 
@@ -2358,7 +2358,7 @@ Node::initializeDefaultKnobs(bool loadingSerialization)
 
 
     if (lastKnobBeforeAdvancedOption && mainPage) {
-        
+
         KnobsVec mainPageChildren = mainPage->getChildren();
         int i = 0;
         for (KnobsVec::iterator it = mainPageChildren.begin(); it != mainPageChildren.end(); ++it, ++i) {
@@ -3164,9 +3164,9 @@ renderPreview(const Image & srcImg,
               bool convertToSrgb,
               unsigned int* dstPixels)
 {
-#ifdef DEBUG
-    // Uncomment if using plugins that generate FP exceptions
-    // boost_adaptbx::floating_point::exception_trapping trap(0);
+#ifndef DEBUG_NAN
+    // Some plugins generate FP exceptions
+    boost_adaptbx::floating_point::exception_trapping trap(0);
 #endif
     ///recompute it after the rescaling
     const RectI & srcBounds = srcImg.getBounds();
@@ -5035,7 +5035,7 @@ Node::onEffectKnobValueChanged(KnobI* what,
         }
         _imp->effect->onEnableOpenGLKnobValueChanged(enabled);
     } else if (what == _imp->processAllLayersKnob.lock().get() ) {
-        
+
         std::map<int, ChannelSelector>::iterator foundOutput = _imp->channelsSelectors.find(-1);
         if (foundOutput != _imp->channelsSelectors.end()) {
             _imp->onLayerChanged(foundOutput->first, foundOutput->second);
@@ -5119,7 +5119,7 @@ Node::onOpenGLEnabledKnobChangedOnProject(bool activated)
         }
     }
     _imp->effect->onEnableOpenGLKnobValueChanged(enabled);
-    
+
 }
 
 bool
@@ -5181,14 +5181,14 @@ Node::Implementation::onLayerChanged(int inputNb,
 
         ///Disable all input selectors as it doesn't make sense to edit them whilst output is All
         for (std::map<int, ChannelSelector>::iterator it = channelsSelectors.begin(); it != channelsSelectors.end(); ++it) {
-            
+
             NodePtr inp;
             if (it->first >= 0) {
                 inp = _publicInterface->getInput(it->first);
             }
             bool mustBeSecret = (it->first >= 0 && !inp.get()) || outputIsAll;
             it->second.layer.lock()->setSecret(mustBeSecret);
-            
+
         }
     }
     if (!isRefreshingInputRelatedData) {
@@ -7247,9 +7247,9 @@ Node::refreshChannelSelectors()
 
 
         KnobChoicePtr channelKnob = it->second.channel.lock();
-        
+
         hasChanged |= channelKnob->populateChoices(choices);
-        
+
     }
     //Notify the effect channels have changed (the viewer needs this)
     _imp->effect->onChannelsSelectorRefreshed();