Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate usage of qSort in ToolButton #717

Merged
merged 1 commit into from Dec 6, 2021
Merged

Conversation

YakoYakoYokuYoku
Copy link
Member

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Beginning with Qt5 most of the offered methods in QAlgorithm that have a corresponding STL counterpart in algorithm are deprecated. This PR substitutes the qSort usage in Gui/ToolButton with std::sort.

Show a few screenshots (if this is a visual change)

N/A.

Have you tested your changes (if applicable)? If so, how?

By building and running the Natron GUI.

Futher details of this pull request

N/A.

@YakoYakoYokuYoku YakoYakoYokuYoku merged commit 654fb40 into RB-2.5 Dec 6, 2021
@YakoYakoYokuYoku YakoYakoYokuYoku deleted the qsort-depr branch December 6, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants