Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitute recursive mutex enum with QRecursiveMutex #720

Merged
merged 1 commit into from Dec 9, 2021

Conversation

YakoYakoYokuYoku
Copy link
Member

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

QMutex::Recursive was deprecated in Qt 5.14 and QRecursiveMutex is recommended to be used instead.

Show a few screenshots (if this is a visual change)

N/A.

Have you tested your changes (if applicable)? If so, how?

Built Natron and used the node graph editor.

Futher details of this pull request

N/A.

@devernay
Copy link
Member

devernay commented Dec 9, 2021

If you prefer, you can work on feature branches on the main repo an make your PRs from there

@devernay devernay merged commit 583860c into NatronGitHub:RB-2.5 Dec 9, 2021
@YakoYakoYokuYoku YakoYakoYokuYoku deleted the qrecursivemutex branch December 9, 2021 02:36
@YakoYakoYokuYoku
Copy link
Member Author

I was thinking to use my fork for more commit heavy PRs, but thanks for letting me know that I can use feature branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants