Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui: added taskbar support #766

Merged
merged 1 commit into from Feb 5, 2022
Merged

Gui: added taskbar support #766

merged 1 commit into from Feb 5, 2022

Conversation

rodlie
Copy link
Contributor

@rodlie rodlie commented Feb 1, 2022

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Enables rendering progress in the taskbar icon on Windows and macOS.

Show a few screenshots (if this is a visual change)

macOS:
natron-taskbar-mac-01 natron-taskbar-mac-02

Didn't have time to take a screenshot on Windows, it looks like any other app that uses the API (green background fill on the icon based on progress).

Have you tested your changes (if applicable)? If so, how?

  • macOS 10.13
  • Windows 10

Futher details of this pull request

See #169

Enables rendering progress in the taskbar icon on Windows and macOS.
@rodlie rodlie added the func:gui label Feb 1, 2022
Copy link
Member

@devernay devernay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@devernay devernay merged commit a34d684 into NatronGitHub:RB-2.4 Feb 5, 2022
@devernay
Copy link
Member

devernay commented Feb 5, 2022

it may break the Qt5 build when merging into RB-2.5.
I'll do the check for macOS, but are you able to check building with Qt5 on Windows @rodlie

@rodlie
Copy link
Contributor Author

rodlie commented Feb 5, 2022

but are you able to check building with Qt5 on Windows @rodlie

I got a new computer today for Natron development on Windows. Will setup latest MSYS2 (and MSVC, but will not use it yet).

Should be able to test against Qt5 on MSYS2 tomorrow (best case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants