Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial CMake build system implementation #809

Merged
merged 1 commit into from Jul 17, 2022
Merged

Initial CMake build system implementation #809

merged 1 commit into from Jul 17, 2022

Conversation

YakoYakoYokuYoku
Copy link
Member

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • New feature (non-breaking change which adds functionality)

What does this pull request do?

Due to some limitations of the QMake build system, like easily customizing targets for example, I've decided to add a port for CMake alongside the existing QMake. This makes some tasks like doing Shiboken generation or the generation of an Engine Python module much more easier to implement and it let us use Ninja too.

Show a few screenshots (if this is a visual change)

N/A.

Have you tested your changes (if applicable)? If so, how?

By building and running Natron, NatronRenderer, natron-python and the test suite.

Futher details of this pull request

Untested in OSX and Windows. Qt4 is not supported because its absense in many upstream package distributions.

Copy link
Member

@devernay devernay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why were RotoGui.cpp and RotoGui.h removed?

@YakoYakoYokuYoku
Copy link
Member Author

YakoYakoYokuYoku commented Jun 18, 2022

Those two files are in fact actually not used anywhere, they are not in Gui.pro and they were deleted at some point (can't get the sig of the commit, I lost track of it the hash is a11e076).

Copy link
Member

@devernay devernay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are non-breaking changes (my only concern was the removal of RotoGui.*)

@devernay devernay merged commit 040fff7 into RB-2.5 Jul 17, 2022
@YakoYakoYokuYoku YakoYakoYokuYoku deleted the cmake-build branch July 17, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants