Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine/CLArgs.cpp: allow dot in writer name #840

Merged
merged 1 commit into from Oct 27, 2022

Conversation

rodlie
Copy link
Contributor

@rodlie rodlie commented Oct 24, 2022

Allow access to writers in a group, see https://discuss.pixls.us/t/rendering-nested-write-nodes/33225

Tested on Windows 11 (NatronRenderer project.ntp -w Group1.Write1).

@devernay devernay merged commit f5c6775 into NatronGitHub:RB-2.4 Oct 27, 2022
@devernay
Copy link
Member

@rodlie would you be ready for a 2.4.4 release?

@devernay
Copy link
Member

(python 2.7)

@rodlie
Copy link
Contributor Author

rodlie commented Nov 12, 2022

Yes, I have a dedicated machine for building RB-2.4, but I have not updated the SDK in a while (OIIO etc).

@devernay
Copy link
Member

I think that's ok, the goal is to fix bugs and bring the few new features.
OIIO and ffmpeg updates may be valuable, but not necessary.

@rodlie
Copy link
Contributor Author

rodlie commented Nov 12, 2022

Ok, it will then be built against the same SDK as v2.4.3. The machine is up and running.

@rodlie
Copy link
Contributor Author

rodlie commented Nov 13, 2022

BayMax test fails compared to 2.4.3, will need to figure out why.

@@ -195,7 +195,7 @@
 TestVectorToColor : PASS
 TestWave : PASS
 TestZMask : PASS
-BayMax : PASS
+BayMax : FAIL
 GNUVolador : PASS
 Spaceship : PASS
 TestCMD/WriteOIIO1 : PASS

Ref:
BayMax-reference8
Out:
BayMax-output8
Diff:
BayMax-comp8

@rodlie
Copy link
Contributor Author

rodlie commented Nov 14, 2022

So, it's not a problem with the SDK, as building v2.4.3 results in BayMax PASS.

@devernay
Copy link
Member

that was a hard one!

culprid: NatronGitHub/openfx-io#23

since YRotate and XRotate don't have the same defaults, this changed the SeNoise default behavior.

Fix:
NatronGitHub/openfx-io@a0fa5d7

@rodlie
Copy link
Contributor Author

rodlie commented Nov 15, 2022

Great 👍

Just got to work, but will remote in to the machine and start a new build.

I upgraded OIIO from 2.3.11 to 2.3.21 and FFmpeg from 4.4. to 4.4.3. I will not go beyond OIIO 2.3.x and FFmpeg 4.4.x for RB-2.4 (to keep compatibility and don't introduce new issues).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants