Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadSVG 4.0 #25

Open
3 of 5 tasks
rodlie opened this issue Jun 11, 2024 · 4 comments
Open
3 of 5 tasks

ReadSVG 4.0 #25

rodlie opened this issue Jun 11, 2024 · 4 comments
Assignees
@rodlie
Labels
cairo enhancement New feature or request svg

Comments

@rodlie
Copy link
Collaborator

rodlie commented Jun 11, 2024 •
edited
Loading

As discussed in NatronGitHub/Natron#970 add basic transform to ReadSVG.

  • Create a cairo helper class (we have more cairo-based plugins that can share code)
  • Integrate OFX transform helpers
  • Add transform support
  • Test new params (work as expected?)
  • Add unit tests for new functions
@rodlie rodlie added the enhancement New feature or request label Jun 11, 2024
@rodlie rodlie self-assigned this Jun 11, 2024
rodlie added a commit that referenced this issue Jun 11, 2024
@rodlie
Initial CairoHelper
61543e4 
Added a new class for common cairo functions.

* #25
* NatronGitHub/Natron#970
@rodlie rodlie mentioned this issue Jun 11, 2024
Closed
10 tasks
rodlie added a commit that referenced this issue Jun 11, 2024
@rodlie
Update CairoHelper
00ef270 
* #25
* NatronGitHub/Natron#970
rodlie added a commit that referenced this issue Jun 11, 2024
@rodlie
Update ReadSVG.cpp
106aa7f 
Add transform support (WIP)

* #25
* NatronGitHub/Natron#970
@rodlie
Copy link
Collaborator Author

rodlie commented Jun 11, 2024

Got POC working in the cairo branch, will continue later this week.

@rodlie rodlie pinned this issue Jun 11, 2024
@rodlie rodlie changed the title ReadSVG: add transform ReadSVG 4.0 Jun 11, 2024
rodlie added a commit that referenced this issue Jun 12, 2024
@rodlie
Update ReadSVG
8112cea 
Transforms seems to work ...

Only tested on Ubuntu with the Natron logo.

* #25
* NatronGitHub/Natron#970
@rodlie
Copy link
Collaborator Author

rodlie commented Jun 12, 2024

So, things seems to work. Needs more testing, I only used Ubuntu 22.04 with Natron RB-2.5.

readsvg4-001-2024-06-12_19.01.55.mp4

But, keyframes don't work (and no interact, not that important)

readsvg4-002-2024-06-12_19.17.57.mp4

(node resize is not related, this is a Qt5 issue)

@devernay
Copy link
Member

hum any idea why keyframes/animation don't work?

@rodlie
Copy link
Collaborator Author

rodlie commented Jun 13, 2024

Unsure, probably something in IOSupport.

Will check when I get the time, maybe later tonight else this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodlie rodlie

Labels
cairo enhancement New feature or request svg
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devernay @rodlie