#6: Remove print statements, replace with QgsMessageLog #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdugge thanks for the patch? have you tested it > is it safe to commit it and push a new version of the plugin? I have no time at the moment to test the patch. |
|
I'll test it in more detail tonight and let you know. |
|
I tested the patch and it works well on my system (imports 300+ photos, error messages written to the log instead of printed on the console). I would say it's safe to merge. Thanks for this very useful plugin! |
@jdugge thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
printstatements and replacing them with log messages where appropriate avoids an overflow when the console is not open.