Fix original image downloads #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.11.4 isn't compatible with jquery 3.x whereas 1.12.1 is.
It's just causing confusion by being here. There's no doc telling devs how to use it, bower is old now and not recommended by the developers and the version of jquery ui installed in the vendors dir wasn't even the same one as specified in the bower config, so, there's no point in keeping it really.
All of the tooltip stuff is defined in ckanext-nhm so I have literally no idea why any of it would be in here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a friend on ckanext-nhm (NaturalHistoryMuseum/ckanext-nhm#454) which fixes bits too. The two issues that needed fixing were:
Then there's some restyling and icon correction.
Fixes: https://github.com/NaturalHistoryMuseum/data-portal/issues/385