Update manifest generation to be more compliant and more usable #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't need to know/hard code the iiif image server profile - remove the requirement that these iiif dicts are only added for vfactor This is predicated on the image URL in the record being an actual image URL which is a change to the way the vfactor records worked, but it makes waaay more sense and mean it works immediately for the specimen collection too.
If the image is coming from our IIIF server it will be but if the image isn't actually being served by a IIIF server it could be anything. This may be unnecessary quite frankly but hey ho.
This is incorrect. I've seen manifests that point to the full/max/0/default.jpg version but I think given our base image endpoints at /media/{id} show an image this makes sense. If you get the manifest and you want to get the info.json (or indeed any IIIF iamge data) you just add it to the end of the URL which is nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the manifest record level builder was basically designed to work with one dataset we have on the NHM Data Portal and nothing else. Now that is not the case!
This PR also tidies up some parts of the manifest generation so that the resulting manifest is more compliant with the various viewers.