Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upsert records validation #43

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add upsert records validation #43

wants to merge 4 commits into from

Conversation

jrdh
Copy link
Member

@jrdh jrdh commented Mar 15, 2021

Records param can't be more than 10MiB now and can't be longer than 20000.

Stop users sending millions of records at once. Limit is set to 10MiB (pretty arbitrary number!).
@coveralls
Copy link

coveralls commented Mar 15, 2021

Pull Request Test Coverage Report for Build 289

  • 14 of 16 (87.5%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 44.822%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ckanext/versioned_datastore/logic/actions/crud.py 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
ckanext/versioned_datastore/logic/actions/crud.py 1 31.71%
Totals Coverage Status
Change from base Build 284: 0.2%
Covered Lines: 1173
Relevant Lines: 2617

💛 - Coveralls

It's 20000, but that's just a random number I came up with, same
as the 10MiB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants