Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for images loaded using imageio #113

Closed
quicklizard99 opened this issue Oct 19, 2021 · 0 comments · Fixed by #114
Closed

Add support for images loaded using imageio #113

quicklizard99 opened this issue Oct 19, 2021 · 0 comments · Fixed by #114
Assignees
@quicklizard99

Comments

@quicklizard99
Copy link
Member

The current implementation of type checking in _pixel_data does not detect images loaded by imageio because these are a subclass of np.ndarray.

Reported by @isman7
@quicklizard99 quicklizard99 self-assigned this Oct 19, 2021
@quicklizard99 quicklizard99 linked a pull request Oct 19, 2021 that will close this issue
Add support for imageio subclassed numpy array. #69
Closed
quicklizard99 added a commit that referenced this issue Oct 19, 2021
@quicklizard99
[#113] Add support for images loaded using imageio
eb02607
@quicklizard99 quicklizard99 mentioned this issue Oct 19, 2021
Merged
quicklizard99 added a commit that referenced this issue Oct 20, 2021
@quicklizard99
[#113] Typo
56eb072
quicklizard99 added a commit that referenced this issue Oct 20, 2021
@quicklizard99
[#113] Add support for images loaded using imageio
566daaf
quicklizard99 added a commit that referenced this issue Oct 20, 2021
@quicklizard99
[#113] Typo
bd4a3aa
quicklizard99 added a commit that referenced this issue Oct 20, 2021
@quicklizard99
[#113] Rebase master
a00af24
quicklizard99 added a commit that referenced this issue Oct 20, 2021
@quicklizard99
Merge pull request #114 from NaturalHistoryMuseum/feature/113-imageio
988ed66 
[#113] Support images loaded using imageio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quicklizard99 quicklizard99

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@quicklizard99