Added ability to configure ZBar options per symbol #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - added optional config parameter to pyzbar.pyzbar.decode - the structure is a nested dictionary where the keys are ZBarSymbol objects, and the values are dicts of ZBarConfig-value key-value pairs Explanation: I am submitting this PR to accomodate our use case of using I25 barcodes that are only 2 digits. ZBar defaults to a minimum length of 6 for I25 codes, and we had no way to change that in the current pyzbar. While I was in the code, I figured I would make it generic to allow changing any config option(s) for any symbol. The structure of the config object is admittedly a bit complicated. I decided to make it a nested dict for 2 reasons: 1. to allow changing barcode settings for each individual code rather than for all codes 2. to allow passing only the config object without passing the symbols object
|
@quicklizard99 Please let me know if this could be included in the next release as it includes changes we need for our use of pyzbar at Chick-fil-A. If not we will have to build our own package based on my fork. Thanks. |
|
@quicklizard99 any updates? We are hoping to continue using the main repo rather than our own fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Explanation:
I am submitting this PR to accomodate our use case of using I25 barcodes that are only 2 digits. ZBar defaults to a minimum length of 6 for I25 codes, and we had no way to change that in the current pyzbar. While I was in the code, I figured I would make it generic to allow changing any config option(s) for any symbol.
The structure of the config object is admittedly a bit complicated. I decided to make it a nested dict for 2 reasons: