Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spellcheck #202

Merged
merged 6 commits into from Dec 15, 2014
Merged

Spellcheck #202

merged 6 commits into from Dec 15, 2014

Conversation

mbc1990
Copy link
Contributor

@mbc1990 mbc1990 commented Dec 15, 2014

Spellcheck based on http://norvig.com/spell-correct.html. Features probabilistic correction suggestion and trie-backed boolean existence lookup.

@kkoch986
Copy link
Member

looks great! Just curious is there a reason for implementing edits instead of using one of the natural distance calculators? At a quick glance it looks similar to Levenshtein Distance

@mbc1990
Copy link
Contributor Author

mbc1990 commented Dec 15, 2014

It is sort of a reverse-Levenshtein that returns all strings 1 edit-distance away from the input. I didn't see that functionality in any of the distance metrics, but if I'm missing something I'd be happy to refactor it.

@kkoch986
Copy link
Member

makes sense, i almost wonder if it makes sense to include that in the distance classes, but i think its fine where it is for now. Thanks for getting this in! I thought it would be a great fit after seeing the article on HN

kkoch986 added a commit that referenced this pull request Dec 15, 2014
@kkoch986 kkoch986 merged commit 2c14932 into NaturalNode:master Dec 15, 2014
@mbc1990 mbc1990 deleted the spelling-corrector branch December 15, 2014 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants