Skip to content
This repository has been archived by the owner on Feb 5, 2023. It is now read-only.

Add source url of git coin donation, so other people can quickly get into it and make donation #128

Closed
AmagiDDmxh opened this issue Nov 24, 2021 · 2 comments

Comments

@AmagiDDmxh
Copy link
Contributor

AmagiDDmxh commented Nov 24, 2021

Is your feature request related to a problem? Please describe.
When I check out other peoples donation details page, such as DIYGod's donations. I may wanna do the same donation, but I can't find the git coin grant source url.

Describe the solution you'd like
Add a field on the details page to allow people to quickly get into it. Lets preview the page in bash, such as:

# the page of DIYGod's donation detail page, where https://diygod.rss3.bio/singlegitcoin/EVM+/0xC8b960D09C0078c18Dcbe7eB9AB9d816BcCa8944/0x8c23B96f2fb77AaE1ac2832debEE30f09da7af3C/Gitcoin-Donation

Nav back [Image]

RSS3 - RSS with human curation
[link to project website](https://rss3.io) - [source to grant page](https://gitcoin.co/grants/2679/rss3-rss-with-human-curation)

Description
balabla...

...

Describe alternatives you've considered
is Null yet

Additional context
if Null or this is not in priority, I'll make a PR about it

@Atlasoin
Copy link
Member

Hi Amagi!

Thanks for your suggestion. It sounds a good idea to add gitcoin original link!

Yeah... but unfortunately this is not in priority, if you'd like to help, we really appreciate it!

Generally I believe an id attribute should be added to the interface GrantInfo, and then here you can get the grant id when loading gitcoin item. Finally you could build the gitcoin original url :)

Please update here in case you encounter any other problem.

Thanks so much.

@AmagiDDmxh
Copy link
Contributor Author

AmagiDDmxh commented Nov 30, 2021

Done, Any suggestion on UI change would be nice.
#135
image

Candinya added a commit that referenced this issue Dec 1, 2021
Add grants link on donation detail page
resolve #128
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants