Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Search Engine Service resources and data #255

Merged
merged 30 commits into from
Jan 19, 2023

Conversation

hyungbin-yea
Copy link
Contributor

@hyungbin-yea hyungbin-yea commented Dec 22, 2022

Description

Features

Resource

  • ses_cluster

Datasource

  • ses_cluster
  • ses_clusters
  • ses_node_os_images
  • ses_node_products
  • ses_versions

Test

Test Env

TestCode

=== RUN   TestAccDataSourceNcloudSESClusters
=== PAUSE TestAccDataSourceNcloudSESClusters
=== CONT  TestAccDataSourceNcloudSESClusters
--- PASS: TestAccDataSourceNcloudSESClusters (2.48s)
=== RUN   TestAccDataSourceNcloudSESSoftwareProductCodes
=== PAUSE TestAccDataSourceNcloudSESSoftwareProductCodes
=== CONT  TestAccDataSourceNcloudSESSoftwareProductCodes
--- PASS: TestAccDataSourceNcloudSESSoftwareProductCodes (2.17s)
=== RUN   TestAccDataSourceNcloudSESSoftwareProductCodesFilter
=== PAUSE TestAccDataSourceNcloudSESSoftwareProductCodesFilter
=== CONT  TestAccDataSourceNcloudSESSoftwareProductCodesFilter
--- PASS: TestAccDataSourceNcloudSESSoftwareProductCodesFilter (1.74s)
=== RUN   TestAccDataSourceNcloudSESNodeProductCodes
=== PAUSE TestAccDataSourceNcloudSESNodeProductCodes
=== CONT  TestAccDataSourceNcloudSESNodeProductCodes
--- PASS: TestAccDataSourceNcloudSESNodeProductCodes (58.63s)
=== RUN   TestAccDataSourceNcloudSESVersions
=== PAUSE TestAccDataSourceNcloudSESVersions
=== CONT  TestAccDataSourceNcloudSESVersions
--- PASS: TestAccDataSourceNcloudSESVersions (1.99s)
=== RUN   TestAccDataSourceNcloudSESCluster
=== PAUSE TestAccDataSourceNcloudSESCluster
=== CONT  TestAccDataSourceNcloudSESCluster
--- PASS: TestAccDataSourceNcloudSESCluster (779.69s)
=== RUN   TestAccResourceNcloudSESCluster_basic
=== PAUSE TestAccResourceNcloudSESCluster_basic
=== CONT  TestAccResourceNcloudSESCluster_basic
--- PASS: TestAccResourceNcloudSESCluster_basic (768.70s)

docs/data-sources/ses_versions.md Outdated Show resolved Hide resolved
ncloud/resource_ncloud_ses_cluster.go Outdated Show resolved Hide resolved
docs/resources/resource_ses_cluster.md Outdated Show resolved Hide resolved
ncloud/resource_ncloud_ses_cluster.go Outdated Show resolved Hide resolved
ncloud/resource_ncloud_ses_cluster.go Show resolved Hide resolved
docs/resources/resource_ses_cluster.md Outdated Show resolved Hide resolved
examples/ses/main.tf Outdated Show resolved Hide resolved
examples/ses/main.tf Outdated Show resolved Hide resolved
@hyungbin-yea
Copy link
Contributor Author

@wonchulee 님, 안녕하세요!
리뷰 감사합니다!

리뷰 해주신 내용들 반영하였습니다. 확인 부탁드릴게요!

  • go-sdk 도 다시 한 번 pull 부탁드릴게요 ㅠ.ㅠ 에러 메시지가 에러 코드만 나오는것 같아 바디도 나오도록 수정하였습니다.

Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 잘 작성해주셔서 리뷰하기가 쉬웠습니다. 수고하셨습니다!
(릴리즈 참고: 해당 PR 반영시 연관 go-sdk 변경사항이 선 반영되어야 하며, 중간에 머지 커밋이 끼어있어, 반영시 스쿼시 머지로 반영하는 것이 좋겠습니다.)

@wonchulee wonchulee changed the title feat: add Search Engine Service resources and data feat: Add Search Engine Service resources and data Jan 10, 2023
…ions" attribute to "images" in data_source_ncloud_ses_node_os_images
@hyungbin-yea
Copy link
Contributor Author

@minosmlee 님, 안녕하세요.
리뷰 감사합니다!

코멘트 반영하여 수정하였습니다. 확인 부탁드리겠습니다 (_ _)


output에 "timeouts" = null 값이 출력됩니다. 출력되지 않도록 해야하겠습니다. 이 부분도 확인 부탁드리겠습니다

@hyungbin-yea
Copy link
Contributor Author

  • Produce Code 변경 시, 노드 스펙 변경 API 호출하도록 수정하였습니다.
    • go sdk 다시 한 번 pull 부탁드립니다.

일부 docs의 형식을 맞추었습니다.
@minosmlee
Copy link
Contributor

@hyungbin-yea 님, 현재 까지 코멘트 남긴것들 제외하고는 모두 잘 동작하는 것을 확인하였습니다.
박예진님 QA완료 되면 릴리즈 가능할것같습니다~~

이와같은 형태로 제시하면 좋을거같네요.
Copy link
Contributor

@minosmlee minosmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 고생하셨습니다.

Copy link
Collaborator

@youngmn youngmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hyungbin-yea
Copy link
Contributor Author

Product

  • Search Engine Service(VPC)

Features

@wonchulee wonchulee merged commit 868a980 into NaverCloudPlatform:master Jan 19, 2023
@jjanga303
Copy link

민간/금융 리얼에서 QA 완료하였습니다.

  • 클러스터 생성
  • 클러스터 삭제
  • 클러스터 노드 스펙 변경
  • 클러스터 노드 추가
  • 클러스터 인증키 변경
  • 클러스터 패스워드 초기화

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants