-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Search Engine Service resources and data #255
feat: Add Search Engine Service resources and data #255
Conversation
# Conflicts: # ncloud/config.go
…de attribute's description
@wonchulee 님, 안녕하세요! 리뷰 해주신 내용들 반영하였습니다. 확인 부탁드릴게요!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, 잘 작성해주셔서 리뷰하기가 쉬웠습니다. 수고하셨습니다!
(릴리즈 참고: 해당 PR 반영시 연관 go-sdk 변경사항이 선 반영되어야 하며, 중간에 머지 커밋이 끼어있어, 반영시 스쿼시 머지로 반영하는 것이 좋겠습니다.)
…ions" attribute to "images" in data_source_ncloud_ses_node_os_images
… is_master_only_node_activated field & master_node block optional)
…unt) & validate data node count's min value
@minosmlee 님, 안녕하세요. 코멘트 반영하여 수정하였습니다. 확인 부탁드리겠습니다 (_ _)
|
|
일부 docs의 형식을 맞추었습니다.
@hyungbin-yea 님, 현재 까지 코멘트 남긴것들 제외하고는 모두 잘 동작하는 것을 확인하였습니다. |
이와같은 형태로 제시하면 좋을거같네요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 고생하셨습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Product
Features
|
민간/금융 리얼에서 QA 완료하였습니다.
|
Description
Features
Resource
Datasource
Test
Test Env
TestCode