New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement, bug fix (#56) and refactoring #57

Open

gsrana1992 wants to merge 7 commits into NayakwadiS:master from gsrana1992:performance-improvement

gsrana1992 commented Nov 16, 2023

Added refactor_scheme_codes.py to help convert the list of scheme_codes in const.json file to a dictionary so the is_code performance will be improved.
is_code method is refactored to directly return the intended boolean result.
is_holiday function in utils.py is similarly refactored as well.
getting import error due to relative import #56 is fixed to reference the util.pym corrently.
Added 2 test cases for is_code method.

gsrana1992 added 7 commits

November 16, 2023 16:50


          updated is_holiday function.


          added refactor_scheme_codes.py

650c803


          fixed reference to const.json fixed.

f860eef


          fixed Import error. NayakwadiS#56

b2dd7c6


          updated scheme codes in const.json file.

24ed1fa


          update is_code method.

0a9ea31


          added tests cases for is_code method.

ba32282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment