Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy button added #38 #44

Merged
merged 1 commit into from
Oct 22, 2022
Merged

copy button added #38 #44

merged 1 commit into from
Oct 22, 2022

Conversation

raghavpatidar
Copy link
Contributor

When the website renders or refreshes, a new room id is produced, and next to it is a copy button that copies the room id to the clipboard. I have now removed the generate button.

@NazimFilzer
Copy link
Owner

NazimFilzer commented Oct 22, 2022

Its working flawlessly! Also, I have one more issue related to this copying stuff.. U wanna Work on it?

@raghavpatidar
Copy link
Contributor Author

I'll work on that, for sure  briefly explain the issue.

@NazimFilzer
Copy link
Owner

I'll work on that, for sure  briefly explain the issue.

image
As u see here The Room Id here Should be Copyable.. Any Ideas?. Should we keep a Button Nxt to it or While Clicking it it should be copied ?

@NazimFilzer NazimFilzer merged commit d4204d8 into NazimFilzer:main Oct 22, 2022
@raghavpatidar
Copy link
Contributor Author

raghavpatidar commented Oct 22, 2022

The best option, in my opinion, is to include a tiny copy icon button next to roomid so we can copy it to the clipboard.
for example like this
image

@raghavpatidar
Copy link
Contributor Author

If you want me to add this feature please make this an issue and Assing it to me.

@NazimFilzer
Copy link
Owner

The best option, in my opinion, is to include a tiny copy icon button next to roomid so we can copy it to the clipboard. for example like this image

Ohk Carry on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants