Feature/9 startpage #138
Feature/9 startpage #138
Conversation
Now, instead of having all video-player controls, the user can skip the intro by pressing anywhere.
# Conflicts: # app/src/main/java/at/vunfer/openrealms/MainActivity.java # app/src/main/java/at/vunfer/openrealms/model/PlayArea.java # app/src/test/java/at/vunfer/openrealms/model/PlayAreaTest.java
- Clicking Join will no longer crash if no/the wrong IP is entered. - After clicking Join, the user must no longer click Start afterwards. - After starting, the user will see a loading screen until the host has joined as well and started the game. - (internal) OverlayView is now added in the XML, instead of startGame()
- Updated view to be more in line with menu.xml and join.xml - Replaced background image to avoid stretching - After clicking Host, the user must no longer click 5 different buttons, before the client can join.
…re a client joined, by removing the join game button.
# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/at/vunfer/openrealms/MainActivity.java # app/src/main/java/at/vunfer/openrealms/model/PlayArea.java # app/src/main/java/at/vunfer/openrealms/network/DataKey.java # app/src/main/java/at/vunfer/openrealms/network/MessageType.java # app/src/main/java/at/vunfer/openrealms/network/server/ClientHandler.java # app/src/main/java/at/vunfer/openrealms/network/server/MessageHandler.java # app/src/main/java/at/vunfer/openrealms/view/OverlayView.java # app/src/test/java/at/vunfer/openrealms/model/PlayAreaTest.java
- Use already-defined constant 'logTag' instead of duplicating its value here. - Make the enclosing method "static" or remove this set. - End this switch case with an unconditional break, - Define and throw a dedicated exception instead of using a generic one. - Make this anonymous inner class a lambda
|
Kudos, SonarCloud Quality Gate passed! |
|
Though coverage may seem low, this PR will still result in an increased total coverage of the main branch. |
There was a problem hiding this comment.
I'm really impressed with the design changes made in this pull request. The overhaul of the main menu and post-game elements brings a fresh and polished look to the application. I also appreciate the improvements like allowing players to choose a name in the main menu. Overall, these changes have been executed exceptionally well, and I'm really impressed with the outcome.
There was a problem hiding this comment.
Dear Ben,
I am writing to express my appreciation and approval of the comprehensive changes made to our application's main menu and post-game experiences.
The enhancements brought to the game, including the introduction of a cinematic, AI backgrounds for the menus, and a new background track, significantly elevate the user experience. Moreover, I am particularly impressed by the improved connection process which simplifies the game setup by reducing unnecessary interactions and eliminating potential crashes.
Adding the option for players to select their own names directly from the main menu is a thoughtful feature that will personalize and enhance the user experience. The ability to rematch an opponent or return to the main menu after a game adds to the continuity of the game, providing users with a smoother gaming experience.
The refactoring of the loading screen elegantly masks the game initialization, further contributing to a seamless user journey.
Overall, the update successfully balances functional improvements and aesthetic upgrades. I commend the dedication and attention to detail reflected in this work. Even if the coverage could be a little higher.
I hereby approve this pull request and look forward to its positive impact on our user experience.
Overhauled main menu and post game stuff.