Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes case-sensitive autocomplete on module menu #44

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

audibleblink
Copy link
Contributor

@audibleblink audibleblink commented Jan 19, 2019

  • lint pass

Pull Request (PR) Checklist

  • I have read the CONTRIBUTING doc
  • PR is from a topic/feature/bugfix branch off the dev branch (right side)
  • PR is against the dev branch (left side)
  • Merlin compiles without errors
  • Passes linting checks and unit tests
  • Updated CHANGELOG
  • Updated README documentation (if applicable)

Change Type

  • Bugfix
  • Addition
  • Modification
  • Removal
  • Security

Description

Auto-completion in the Module menu wasn't expanding Agent because of case-sensitivity. The GUI shows Agent but the completor function was expecting a<tab>. This PR brings the behavior back to normal, matching the way completion is done in the rest of the menus.

Also my editor's linter changed some things.

@Ne0nd0g
Copy link
Owner

Ne0nd0g commented Jan 20, 2019

Can please update the changelog too? I would be fine with you using the same version number as pull request #43 . Nice work on this PR. I know the capital A was tripping people up.

@audibleblink
Copy link
Contributor Author

@Ne0nd0g updated

Copy link
Owner

@Ne0nd0g Ne0nd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Agent versus agent thing was annoying. Thank you for updating it to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants