Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes small typo in README.md #1

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Fixes small typo in README.md #1

merged 2 commits into from
Aug 20, 2021

Conversation

NLueg
Copy link
Contributor

@NLueg NLueg commented Aug 20, 2021

Thank you for your plugin!
Just integrated it and feels awesome after integrating your Demo code.

I just found a small typo when copy & pasting your code.
Also, I saw that you just check if the promise is given in the if and not use the result of the promise.

@NePheus
Copy link
Owner

NePheus commented Aug 20, 2021

Thanks for your feedback and contributing!

@NePheus NePheus merged commit 53e7f01 into NePheus:master Aug 20, 2021
@NLueg NLueg deleted the patch-1 branch August 21, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants