Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CUSTOMER ACCOUNT LOG ENTRIES on a CUSTOMER ACCOUNT #217

Open
skinkie opened this issue Aug 18, 2021 · 5 comments
Open

Add support for CUSTOMER ACCOUNT LOG ENTRIES on a CUSTOMER ACCOUNT #217

skinkie opened this issue Aug 18, 2021 · 5 comments
Milestone

Comments

@skinkie
Copy link
Contributor

skinkie commented Aug 18, 2021

#137

Needs documentation

@skinkie skinkie added the needs documentation update The NeTEx document needs to be updated label Aug 18, 2021
@ue71603 ue71603 added this to the netex_1.3 milestone Apr 19, 2022
@nick-knowles
Copy link
Contributor

nick-knowles commented Dec 9, 2023

Currently, in Transmodel and NeTEx, CUSTOMER ACCOUNT LOG ENTRIES are linked to a CUSTOMER ACCOUNT via a FARE CONTRACT, that is a FARE CONTRACT must be created to hold the account log entries; thus a dummy FARE CONTRACT must be created for the account itself to record and log entries before any sales transactions have taken place for the account. This is not unreasonable - the account itself entails a "contract" between the customer and operator to hold and account and manage the customers details according to certain terms and conditions. . The CUSTOMER ACCOUNT LOG ENTRIES do however have a reference to the relevant account so can readily be associated with it.

If people think it really necessary, for convenience in NETEx for the purposes of data exchange, one could add a list of LOG ENTRY references also to the CUSTOMER ACCOUNT but this would be redundant from a modelling point of view

This is the current model
image

@nick-knowles
Copy link
Contributor

Added to NeTEX UML as convenience feature. (not needed in Transmodel)

image

@ue71603 ue71603 modified the milestones: netex_1.3, netex_2.0 Jan 6, 2024
@ue71603 ue71603 assigned trurlurl and unassigned seime, nick-knowles, Aurige and trurlurl May 8, 2024
@ue71603
Copy link
Contributor

ue71603 commented May 8, 2024

@trurlurl if input from @Aurige is necessary just ask him.

@trurlurl
Copy link
Collaborator

Replicating the update to the UML model would mean adding an element entries to CustomerAccount. The entries of type fareContractEntryRefs_RelStructure would collect references to each of the log entries that are hold in a "dummy" / dedicated FareContract. Is that correct?

When transferring CustomerAccount data, the sender would have to collect the log entries from the dedicated FareContract and pack the references in CustomerAccount.entries. The FareContract in question has also made sure to be included somewhere. That's quite complicated. Easier would be to transfer CustomerAccount.entries as a duplicate of the FareContract.entries, i.e., of type fareContractEntries_RelStructure. But then, why not having just that element (CustomerAccount.entries), there is no more need for the additional "dummy"/dedicated FareContract?

@nick-knowles Could you help with my unterstanding - do these questions make sense or am I ignorant about some more basic things?

@trurlurl
Copy link
Collaborator

Added a note in the documentation, part 3. Changing milestone to 3.0 as it should be treated as part of PR #137.

@trurlurl trurlurl removed needs documentation update The NeTEx document needs to be updated only_docs_left labels May 31, 2024
@trurlurl trurlurl modified the milestones: netex_2.0, netex_3.0 May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants