Add a check for only lustrefilesystem finalizer before delete #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the PV/PVC cannot be removed while something is still using it (e.g. NNF Data Movement). Signed-off-by: Blake Devcich <blake.devcich@hpe.com>
matthew-richerson
approved these changes
Nov 2, 2023
| // At this point, only our finalizer should be present before access is deleted. If not, | ||
| // requeue until they are gone. | ||
| if !onlyLustreFinalizer(fs) { | ||
| return ctrl.Result{Requeue: true}, nil |
There was a problem hiding this comment.
I don't think you need a requeue here. When a finalizer is deleted, that will generate an event and the reconciler will run
roehrich-hpe
reviewed
Nov 2, 2023
| // Check to see that only the lustre filesystem finalizer exists | ||
| onlyLustreFinalizer := func(o client.Object) bool { | ||
| f := o.GetFinalizers() | ||
| if len(f) == 1 && f[0] == finalizerLustreFileSystem { |
There was a problem hiding this comment.
We got past line 85, so we've already confirmed that the finalizer owned by this controller is present. I think, before line 85 you want to know if there are other finalizers, and return if they are present.
roehrich-hpe
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the PV/PVC cannot be removed while something is still
using it (e.g. NNF Data Movement).
Signed-off-by: Blake Devcich blake.devcich@hpe.com