Use owner UID instead of workflow UID for VG name #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for persistent local file systems. The workflow mounting the persistent file system will have a different UID than the workflow that made the file system. Use the owner UID instead (NnfStorage) since that UID will be consistent for the lifetime of the persistent file system. Also, don't set the file system permissions on ClientMounts in Kind. This will be enabled later when file systems are better mocked out in the kind environment. Signed-off-by: Matt Richerson <matthew.richerson@hpe.com>
ajfloeder
approved these changes
Jan 2, 2024
roehrich-hpe
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for persistent local file systems. The workflow mounting the persistent file system will have a different UID than the workflow that made the file system. Use the owner UID instead (NnfStorage) since that UID will be consistent for the lifetime of the persistent file system.
Also, don't set the file system permissions on ClientMounts in Kind. This will be enabled later when file systems are better mocked out in the kind environment.