Upgrade controller-gen to v0.14.0 and setup-envtest to 3/20/24 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The k8s-go community broke a few things this morning, our time. Signed-off-by: Dean Roehrich <dean.roehrich@hpe.com>
|
The switch to controller-gen v0.14.0 is something we can keep. The pinning of setup-envtest feels like something that ought to be short-term; like maybe the k8s-go folks will revert that breakage by Monday. |
|
The setup-envtest I picked is from two days ago, since the latest one today is broken. Here's where I'm looking for setup-envtest versions: |
bdevcich
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The k8s-go community broke a few things this morning, our time.