feat: add fork data to metadata in the editor #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackson-harris-iii nice job addressing those edge-case bugs |
|
@charleslavon made the changes ✅ |
|
Closes: near/near-discovery#852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: near/near-discovery#852
Here are some test cases for anyone interested in testing the desired behavior.
From the near.social hamburger menu click fork
The IDE should open with the forked component code in focus, there should be a default tab visible.
When switching between tabs the editor should display the code associated with the selected tab
When "saving"(equivalenet to near.org publish) the user should be prompted with a "Saving Data" modal. Ensure that the metadata for the fork_of property is there if the current component is in fact a fork and not there if the component is not a fork.
Ensure that if there are multiple components in the editor that switching between the tabs results in the component data in the active tab of the editor to be displayed in the "Saving Data" modal.
When renaming a forked component the metadata is still properly attributed to the component when publishing