-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix get env typespec #18
Conversation
lib/confex.ex
Outdated
@@ -180,7 +180,7 @@ can not resolve key MY_TEST_ENV value via adapter Elixir.Confex.Adapters.SystemE | |||
...> 1 = #{__MODULE__}.get_env(:myapp, :test_var) | |||
1 | |||
""" | |||
@spec get_env(app :: Application.app(), key :: Application.key()) :: {:ok, Application.value()} | {:error, any()} | |||
@spec get_env(app :: Application.app(), key :: Application.key(), term) :: Application.value() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you, please, name the third argument as it is named in function definition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, thanks!
Wasn't sure how you would prefer the line broken. Happy to change it according to your preferences. |
Great job, thanks! 👍 |
Fixes #17