-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis and Docker acceptance case #40
Open
PavelVesnin
wants to merge
9
commits into
master
Choose a base branch
from
docker_acceptance_test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+65
−4
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f6ac27a
travis acceptance case
PavelVesnin db713ff
Merge branch 'master' into docker_acceptance_test
PavelVesnin beddb39
dogma fix
PavelVesnin cdb7b32
Merge remote-tracking branch 'origin/docker_acceptance_test' into doc…
PavelVesnin 19f2ce8
added httpoison to mix.lock
PavelVesnin 41c2796
removed redundant test assertions
PavelVesnin e7f50ef
run acceptance test only on docker container
PavelVesnin 519ae05
Merge branch 'master' into docker_acceptance_test
gmile b31d2d1
Merge branch 'master' into docker_acceptance_test
gmile File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
defmodule PRM.DummyAcceptanceTest do | ||
use PRM.Support.AcceptanceCase | ||
|
||
test "api" do | ||
"/api" | ||
|> get!() | ||
|> assert_status(404) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @PavelVesnin can we make this check stronger and assert on an API that returns 200? I think |
||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
defmodule PRM.Support.AcceptanceCase do | ||
@moduledoc """ | ||
Acceptance test helper | ||
""" | ||
use ExUnit.CaseTemplate | ||
|
||
using do | ||
repo = | ||
case System.get_env("CONTAINER_HTTP_PORT") do | ||
nil -> PRM.Repo | ||
_ -> nil | ||
end | ||
|
||
quote do | ||
@tag acceptance: true | ||
use EView.AcceptanceCase, | ||
async: false, | ||
otp_app: :prm, | ||
endpoint: PRM.Web.Endpoint, | ||
repo: unquote(repo), | ||
headers: [{"content-type", "application/json"}] | ||
|
||
def assert_validation_error(%HTTPoison.Response{body: body} = response, entry, type) do | ||
assert %{ | ||
"meta" => %{"code" => 422}, | ||
"error" => %{ | ||
"message" => _, | ||
"type" => "validation_failed", | ||
"invalid" => [%{ | ||
"entry" => ^entry, | ||
"entry_type" => ^type, | ||
"rules" => ["required"] | ||
}] | ||
}, | ||
} = body | ||
|
||
response | ||
end | ||
|
||
def assert_status(%HTTPoison.Response{status_code: status_code} = response, status) do | ||
assert status == status_code | ||
response | ||
end | ||
|
||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
ExUnit.start() | ||
if System.get_env("CONTAINER_HTTP_PORT") == nil do | ||
ExUnit.configure(exclude: [acceptance: true]) | ||
Ecto.Adapters.SQL.Sandbox.mode(PRM.Repo, :manual) | ||
end | ||
|
||
Ecto.Adapters.SQL.Sandbox.mode(PRM.Repo, :manual) | ||
ExUnit.start() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(not a blocking comment)
Here
CONTAINER_HTTP_HOST
looks weird in isolation. It's hard to get what is it used for, unless you know what you're looking for (one has to look up theeview
sources for it).Opened an issue in eview – Nebo15/eview#6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually ignore this, my bad. I was searching for usage of
CONTAINER_HTTP_HOST
and found it ineview
. But it appears it's no other that a name clash.