Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github short hash to all services #448

Merged
merged 1 commit into from
May 13, 2022

Conversation

posterzh
Copy link
Contributor

Issue

  • Link: gateway_mfr exited with a non-zero status hm-diag#352
  • Summary:
    There are many Sentry issues related with "gateway_mfr exited with a non-zero status" in hm-diag.
    This is most likely happening if not all services get restarted when we release a new version to the Balena fleets.
    As a convention, we update the FIRMWARE_VERSION in the settings.ini in the every version update so that all services restart, but if we forget to update FIRMWARE_VERSION, then it is the case that only some services will restart.

It would be safer and better solution to add FIRMWARE_SHORT_HASH to the environment variable of all the services since its value is generated automatically on every release.

How
Add FIRMWARE_SHORT_HASH environment variable to packet-forwarder and helium-miner service.
The other services already contain this environment variable.

Screenshots

References

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

@posterzh posterzh requested review from a team as code owners May 13, 2022 19:39
@posterzh posterzh merged commit 3911165 into master May 13, 2022
@posterzh posterzh deleted the posterzh/352/add-github-short-hash branch May 13, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants