Add Github short hash to all services #448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There are many Sentry issues related with "gateway_mfr exited with a non-zero status" in
hm-diag
.This is most likely happening if not all services get restarted when we release a new version to the Balena fleets.
As a convention, we update the
FIRMWARE_VERSION
in thesettings.ini
in the every version update so that all services restart, but if we forget to updateFIRMWARE_VERSION
, then it is the case that only some services will restart.It would be safer and better solution to add
FIRMWARE_SHORT_HASH
to the environment variable of all the services since its value is generated automatically on every release.How
Add
FIRMWARE_SHORT_HASH
environment variable topacket-forwarder
andhelium-miner
service.The other services already contain this environment variable.
Screenshots
References
Checklist