Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostic processor should call diag less frequently #202

Closed
2 tasks
pritamghanghas opened this issue Jul 5, 2022 · 4 comments
Closed
2 tasks

Diagnostic processor should call diag less frequently #202

pritamghanghas opened this issue Jul 5, 2022 · 4 comments

Comments

@pritamghanghas
Copy link
Contributor

pritamghanghas commented Jul 5, 2022

currently hm-config calls diagnostic json end point every 60 seconds. In hm-config LedProcessor is its only user.
Side effects of running diagnostics this freqenty:

  1. Diagnostics logs are flooded with debug from perform_hw_diagnostics
  2. I think this is making diag uploads also unreliable, there seems strange flipping of ship=false in some cases.
  3. this keeps ecc busy unnecessarily and might interference with miner operations. (not verified yet if this is having an impact)

Acceptance Criteria:

  • Diagnostics endpoint is only called on demand
  • BT Diagnostics should continue to work and provide up to date diagnostics
@pritamghanghas
Copy link
Contributor Author

this one might be related.

@KevinWassermann94
Copy link
Contributor

This can be merged to production too

@pritamghanghas
Copy link
Contributor Author

pritamghanghas commented Aug 11, 2022 via email

@pritamghanghas
Copy link
Contributor Author

checked again. hm-config hash carrying this is already in production closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants