Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the visuals for the game: pixel art. #30

Merged
merged 38 commits into from
May 24, 2020
Merged

Updating the visuals for the game: pixel art. #30

merged 38 commits into from
May 24, 2020

Conversation

Nebulean
Copy link
Owner

@Nebulean Nebulean commented May 12, 2020

The visuals were messy, so this pull request will change the visuals to pixel art.
I am working on it.

Todo:

  • Players
  • Negative/positive balls
  • Ring -> Still not perfect
  • Powerups
  • Background
  • Main menu
  • Tutorial (not the priority)
  • Replace fonts
  • Electric field sprite -> Done, but not implemented.

Issues:

  • The trails are slightly too big, the balls are smaller.

@Nebulean Nebulean added enhancement New feature or request NOT READY YET The pull request is not yet ready, do not merge. labels May 12, 2020
@Nebulean Nebulean self-assigned this May 12, 2020
@Nebulean Nebulean added this to In Progress in Targeted version May 12, 2020
@Nebulean
Copy link
Owner Author

The first version of all the sprite are now ready (except the tutorial which isn't on the branch yet).
I am open for remarks and critics. ^^
(Except for the ring, I know it is ugly for now)

@Nebulean Nebulean linked an issue May 15, 2020 that may be closed by this pull request
@Nebulean Nebulean added REVIEW NEEDED We just need to be reviewed to merge. and removed NOT READY YET The pull request is not yet ready, do not merge. labels May 15, 2020
@Nebulean Nebulean mentioned this pull request May 18, 2020
2 tasks
@Nebulean Nebulean linked an issue May 18, 2020 that may be closed by this pull request
2 tasks
@Nebulean Nebulean linked an issue May 19, 2020 that may be closed by this pull request
@Nebulean Nebulean linked an issue May 20, 2020 that may be closed by this pull request
@Mojert
Copy link
Collaborator

Mojert commented May 22, 2020

The sprites are pretty good ! I'm especially found of the explosion when the ball goes out of bounds. However I have two problems:

  • I don't think that not allowing to resize the window fixes issue Fix the fullscreen problem #28. It would be better to allow it. Since it's its own issue and this pull request is about pixel-art maybe that untying the two would be the best.
  • The sprite for the electric field should be changed too.

Moreover we still lack a sprite for the magnetic field and the electric field's is only a rectangle even though the effect of the field extends beyond the rectangle. I didn't include those in the check list since these may require their own issue.

@Mojert
Copy link
Collaborator

Mojert commented May 22, 2020

The electric field extending beyond the rectangle is a bug so forget this remark ^^

@Nebulean Nebulean linked an issue May 22, 2020 that may be closed by this pull request
@Nebulean
Copy link
Owner Author

Nebulean commented May 22, 2020

The sprite for the electric field was added, but not implemented as I don't know how to do it without breaking your code. See #38 .

Regarding the resize problem, it is just a temporary fix don't worry. ;)

@Nebulean Nebulean linked an issue May 22, 2020 that may be closed by this pull request
Copy link
Collaborator

@Mojert Mojert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good to me !

@Nebulean Nebulean merged commit b4b143c into master May 24, 2020
Targeted version automation moved this from In Progress to Done May 24, 2020
@Nebulean
Copy link
Owner Author

Everything is patch, the branch will now be merged to master.

@Nebulean Nebulean deleted the pixel-art branch May 24, 2020 14:25
@Nebulean Nebulean linked an issue May 24, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request REVIEW NEEDED We just need to be reviewed to merge.
Projects
No open projects
4 participants