Skip to content
This repository has been archived by the owner on Jan 13, 2020. It is now read-only.

Commit

Permalink
Get rid of the action on D-pad Left in BrowseDialog
Browse files Browse the repository at this point in the history
There is no counterpart action for the opposite direction, D-pad Right.
Having D-pad Left trigger a return to the parent directory was
inconsistent.

Additionally, this frees up the D-pad Left and Right inputs for
something more useful.
  • Loading branch information
Nebuleon committed Oct 7, 2014
1 parent 7862677 commit ee482ae
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/browsedialog.cpp
Expand Up @@ -31,11 +31,9 @@ void BrowseDialog::initButtonBox()
{
buttonBox.clear();

// Left or Cancel to go up a directory, if directories are shown.
// Cancel to go up a directory, if directories are shown.
// Accept also goes up a directory if the selection is "..".
if (fl.getShowDirectories() && getPath() != "/") {
buttonBox.add(unique_ptr<IconButton>(new IconButton(
gmenu2x, "skin:imgs/buttons/left.png")));
if (selected < fl.size() && fl[selected] == "..") {
buttonBox.add(unique_ptr<IconButton>(new IconButton(
gmenu2x, "skin:imgs/buttons/accept.png")));
Expand Down Expand Up @@ -161,7 +159,6 @@ BrowseDialog::Action BrowseDialog::getAction(InputManager::Button button)
return BrowseDialog::ACT_SCROLLUP;
case InputManager::ALTRIGHT:
return BrowseDialog::ACT_SCROLLDOWN;
case InputManager::LEFT:
case InputManager::CANCEL:
return BrowseDialog::ACT_GOUP;
case InputManager::ACCEPT:
Expand Down

0 comments on commit ee482ae

Please sign in to comment.