Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Initial UI Overhaul #794

Merged
merged 5 commits into from Jul 6, 2018
Merged

Initial UI Overhaul #794

merged 5 commits into from Jul 6, 2018

Conversation

eddiewang
Copy link
Contributor

@eddiewang eddiewang commented Jun 27, 2018

ready for merge
ready for review
This PR achieves the following:

Build System:

  • Update packages that are out of date.
  • Rework the webpack build pipline.
  • Add webpack build pipelines for dev mode vs. prod.
  • Use the standard JS lint with prettier-standard for formatting.
  • Add git hooks with husky for lint checks before git commits.
  • Update all js files with new lint rules.
  • Make the html files automatically require between Dev and Prod js builds based on env.
  • Hot reload for react components.
  • CSS live reload for all plugins as well as the global css files.

UI:

  • Rework Header and Sidebar to match new branding guidelines
  • All core plugins updated with slightly more spacing for header components
  • Core plugins updated to match new branding guidelines

The majority of the backend changes made are upgrades to the DX, which will hopefully make contributing to Sia-UI a nicer experience.

With this PR, developers can now run npm run dev to have a fully functional, hot reloadable Sia-UI app. Also, if contributors have different stylistic differences in the way they write code, the git hooks will automatically reformat them to standardjs rules on commit with husky.

Screenshots of the UI:
image
image
image

@eddiewang eddiewang force-pushed the initial-ui-overhaul branch 4 times, most recently from c9fe31c to 8a54fa4 Compare July 2, 2018 19:58
package.json Outdated
],
"plugins/**/*.js": [
"prettier-standard",
"git add"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems weird to me that git would be called directly from package.json. I'd rather have this command just do the linting, and let the user call git add -u separately.

@lukechampine
Copy link
Member

why did the package.json explode in size?

@lukechampine lukechampine merged commit 639abce into master Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants